Fix Generic Evil Bug and Assassin Target Bug #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eric evil knows evil
This was
linked to
issues
Jun 28, 2020
|
Still need to do more testing. Leaving to go hang out next to a river. Will be on later today |
|
Looks like this is also a frontend issue. Will need to make changes in RoleInfoTab |
bbailey27
requested changes
Jul 6, 2020
There was a problem hiding this comment.
1 comment based on looking at the code. roleAssignmentData.js is hard to expand and check but it looks like all the evil characters already had genericEvil in their sees lists? We just happened to play with 2 genericEvil and that was where it was missing? I'll give it a test run when I remember.
| knowsRole: false | ||
| }, | ||
| oberon: { |
There was a problem hiding this comment.
Merlin should see both oberon and generic evil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.